Skip to content

gh-93963: Remove deprecated names from importlib.abc.#94528

Closed
jaraco wants to merge 9 commits into
mainfrom
gh-93963/remove-importlib-resources-abcs
Closed

gh-93963: Remove deprecated names from importlib.abc.#94528
jaraco wants to merge 9 commits into
mainfrom
gh-93963/remove-importlib-resources-abcs

Conversation

@jaraco

@jaraco jaraco commented Jul 3, 2022

Copy link
Copy Markdown
Member

@jaraco jaraco changed the base branch from main to gh-93963/deprecate-importlib-resources-abcs July 3, 2022 14:51
@jaraco jaraco force-pushed the gh-93963/remove-importlib-resources-abcs branch from 3574e94 to 96f14c2 Compare July 3, 2022 14:58
Base automatically changed from gh-93963/deprecate-importlib-resources-abcs to main July 3, 2022 19:17
@jaraco

jaraco commented Jul 24, 2022

Copy link
Copy Markdown
Member Author

I see now in 691a82a, Github did the wrong thing. Apparently, because this repo uses squash merge, thereby rewriting history, Git can't tell that the lines removed in 96f14c2 were to be removed, and instead of complaining that there's a conflict, it just undid that change.

@jaraco

jaraco commented Jul 24, 2022

Copy link
Copy Markdown
Member Author

I've filed a Github support ticket to report the issue to Github and get their opinion on it. In the meantime, 17f614e should work around the issue.

@warsaw

warsaw commented Jul 24, 2022

Copy link
Copy Markdown
Member

I've filed a Github support ticket

Looks like probably only you @jaraco can see that ticket.

@warsaw

warsaw commented Jul 24, 2022

Copy link
Copy Markdown
Member

@jaraco I'm trying to reboot myself on this discussion. @jaraco was the deprecation of access to these ABCs ever documented as deprecated in the library docs? I can't find that. That's not to say that it should hold up removal of these, since the deprecation warnings happened in the code. If we go ahead and remove the b/c hack now, I do think that any documentation update to importlib.resources.abc should explicitly mention the deprecation and removal history of access through importlib.abc.

@jaraco

jaraco commented Jul 29, 2022

Copy link
Copy Markdown
Member Author

Looks like probably only you @jaraco can see that ticket.

Yeah, that's true. That's how Github does things. I linked it here to be transparent about what I'm doing and to associate a reference. Still no response, BTW.

was the deprecation of access to these ABCs ever documented as deprecated in the library docs?

I did not previously include that effort as part of this change because Hugo and others were working on docs updates. The deprecations were subsequently documented in #94546.

@CAM-Gerlach

CAM-Gerlach commented Dec 15, 2022

Copy link
Copy Markdown
Member

Hey @jaraco , what are the next steps here?

Just FYI, following what was discussed in python/core-workflow#475 , this is the only personal feature branch remaining on the upstream cpython repo, which blocks the full implementation of the branch protection rule approved in python/steering-council#144 that would avoid the issue where it is easy to push personal feature branches to the upstream by accident, either through the Git CLI or via GitHub's web Edit feature.

@jaraco

jaraco commented Dec 17, 2022

Copy link
Copy Markdown
Member Author

Let's close this and delete the branch and hope someone can find the changes when the time comes to submit it.

@jaraco jaraco closed this Dec 17, 2022
@jaraco jaraco deleted the gh-93963/remove-importlib-resources-abcs branch December 17, 2022 16:24
@hugovk

hugovk commented May 29, 2024

Copy link
Copy Markdown
Member

Re-done as #119720.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants