Skip to content

Add missing VIEW_EVENT_CASE entries for W3C Pointer Events in BaseViewProps::setProp#56188

Closed
HariniMalothu17 wants to merge 3 commits into
react:mainfrom
HariniMalothu17:main
Closed

Add missing VIEW_EVENT_CASE entries for W3C Pointer Events in BaseViewProps::setProp#56188
HariniMalothu17 wants to merge 3 commits into
react:mainfrom
HariniMalothu17:main

Conversation

@HariniMalothu17

@HariniMalothu17 HariniMalothu17 commented Mar 23, 2026

Copy link
Copy Markdown

Summary:

Resolves microsoft/react-native-windows#15827
ViewEvents::Offset defines enum values for Click, ClickCapture, PointerDown, PointerDownCapture, PointerUp, PointerUpCapture, GotPointerCapture, and LostPointerCapture (offsets 30–37), but BaseViewProps::setProp() has no corresponding VIEW_EVENT_CASE entries for them.

This means when enableCppPropsIteratorSetter() is enabled, these event props (onPointerDown, onPointerUp, onClick, onGotPointerCapture, onLostPointerCapture, and their capture variants) are never parsed from JS — the bits in ViewEvents are never set, so the native side never knows a component is listening for these events.

This PR adds the 8 missing VIEW_EVENT_CASE entries alongside the existing pointer event cases.

Changelog:

Test Plan:

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 23, 2026
…ning (which becomes an error)."

This reverts commit 788d625.
@github-actions

Copy link
Copy Markdown

Warning

JavaScript API change detected

This PR commits an update to ReactNativeApi.d.ts, indicating a change to React Native's public JavaScript API.

  • Please include a clear changelog message.
  • This change will be subject to additional review.

This change was flagged as: BREAKING

@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Mar 23, 2026
@meta-codesync

meta-codesync Bot commented Mar 23, 2026

Copy link
Copy Markdown

@javache has imported this pull request. If you are a Meta employee, you can view this in D97732755.

@meta-codesync meta-codesync Bot closed this in 8d5482d Mar 23, 2026
@react-native-bot

Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by Harini Malothu in 8d5482d

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing W3C pointer event cases and wire up button/buttons on PointerEvent

2 participants