Add missing VIEW_EVENT_CASE entries for W3C Pointer Events in BaseViewProps::setProp#56188
Closed
HariniMalothu17 wants to merge 3 commits into
Closed
Add missing VIEW_EVENT_CASE entries for W3C Pointer Events in BaseViewProps::setProp#56188HariniMalothu17 wants to merge 3 commits into
HariniMalothu17 wants to merge 3 commits into
Conversation
added 2 commits
October 29, 2025 23:01
…ning (which becomes an error)." This reverts commit 788d625.
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
Collaborator
|
This pull request was successfully merged by Harini Malothu in 8d5482d When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Resolves microsoft/react-native-windows#15827
ViewEvents::Offset defines enum values for Click, ClickCapture, PointerDown, PointerDownCapture, PointerUp, PointerUpCapture, GotPointerCapture, and LostPointerCapture (offsets 30–37), but BaseViewProps::setProp() has no corresponding VIEW_EVENT_CASE entries for them.
This means when enableCppPropsIteratorSetter() is enabled, these event props (onPointerDown, onPointerUp, onClick, onGotPointerCapture, onLostPointerCapture, and their capture variants) are never parsed from JS — the bits in ViewEvents are never set, so the native side never knows a component is listening for these events.
This PR adds the 8 missing VIEW_EVENT_CASE entries alongside the existing pointer event cases.
Changelog:
Test Plan: