offset_from, offset: clearly separate safety requirements the user needs to prove from corollaries that automatically follow#127275
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By landing #116675 we decided that objects larger than
isize::MAXcannot exist in the address space of a Rust program, which lets us simplify these rules.For
offset_from, we can even state that the absolute distance fits into anisize, and therefore excludeisize::MIN. This PR also changes Miri to treat anisize::MINdifference like the other isize-overflowing cases.