allow clippy manual ascii check for definitions of them

[hkBst]

No description provided.

[rustbot]

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[jhpratt]

Is clippy run on the standard library? I didn't think that was the case.

[hkBst]

Currently clippy gives a lot of warnings, making it pretty useless, so I'm trying to change that.

[jhpratt]

Is that something the libs team has approved? While a single PR isn't much, a series of them is.

[hkBst]

I haven't asked for specific approval for this idea. If you think that I should, then I'm happy to do that.

[jhpratt]

I think that would be best to avoid doing something the team doesn't ultimately care for. A quick search shows that you've already opened a dozen PRs, which is exactly what I expected. If the team doesn't want to enable clippy in the end, then some of them (like this) wouldn't serve a direct purpose.

[RalfJung]

Yeah, generally please talk to the team(s) before opening a dozen PRs. That's clearly a larger project that needs some coordination.

[workingjubilee]

I do not think we should enable any lints which fire on the implementations of standard library functions inside the standard library.