Track items behind cfg_select in the same way we do for cfg#157218
Open
estebank wants to merge 5 commits into
Open
Track items behind cfg_select in the same way we do for cfg#157218estebank wants to merge 5 commits into
cfg_select in the same way we do for cfg#157218estebank wants to merge 5 commits into
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
Collaborator
|
|
Contributor
Author
|
This or something akin to this is needed for #129249. I'll clean up the code shortly, once I get that PR to the point it can run on crater. |
Collaborator
|
The Cranelift subtree was changed cc @bjorn3 |
2262d01 to
97da0c8
Compare
Contributor
|
(I'd like to look at this, probably tomorrow, because the PR touches expansion infra.) |
estebank
commented
Jun 1, 2026
When annotating an item with `#[cfg]` we track both the item that got annotated (with an inert attr) and the names of items that got directly cfg'd out. Extend this mechanism to also work for items within a `cfg_select!`.
97da0c8 to
677634c
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
petrochenkov
reviewed
Jun 3, 2026
This comment has been minimized.
This comment has been minimized.
76ed1df to
34c1685
Compare
34c1685 to
a04d12d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When annotating an item with
#[cfg]we track both the item that got annotated (with an inert attr) and the names of items that got directly cfg'd out. Extend this mechanism to also work for items within acfg_select!.r? @jdonszelmann
cc @JonathanBrouwer