Use a dummy TypeckResults instead of Option<TypeckResults> when linting

[Jarcho]

Based on #157928

This brings the typeck results when linting back to what it was before #73743. The first four commits are from the first PR and handle eagerly fetching the typeck results and the workaround needed for rustdoc. The fifth commit adds a dummy ownerless typeck results and uses that as the initial value for the lint pass. The final commit just removes the now useless typeck_results method.

The dummy table is added to the global context more for convenience. It can't be a static since the lifetime argument is invariant. It could be created just for the linting, but that would need to add an extra lifetime parameter to LateContext and a lot of places downstream of that which would be a huge pain.

[rustbot]

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

[rustbot]

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 73 candidates
• Random selection from 20 candidates

[folkertdev]

r? types

[Jarcho]

The line the error is complaining about doesn't even exist anywhere. What is the miri test even building?

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[rust-log-analyzer]

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

    Checking rustc_codegen_ssa v0.0.0 (/checkout/compiler/rustc_codegen_ssa)
error[E0599]: no method named `typeck_results` found for reference `&LateContext<'tcx>` in the current scope
   --> compiler/rustc_lint/src/noop_method_call.rs:149:41
    |
149 |             let unadjusted_expr_ty = cx.typeck_results().expr_ty(expr);
    |                                         ^^^^^^^^^^^^^^ field, not a method
    |
help: remove the arguments
    |
149 -             let unadjusted_expr_ty = cx.typeck_results().expr_ty(expr);
149 +             let unadjusted_expr_ty = cx.typeck_results.expr_ty(expr);
    |
help: there is a method `to_result` with a similar name
    |
149 -             let unadjusted_expr_ty = cx.typeck_results().expr_ty(expr);
149 +             let unadjusted_expr_ty = cx.to_result().expr_ty(expr);
    |

For more information about this error, try `rustc --explain E0599`.
[RUSTC-TIMING] rustc_lint test:false 3.126
error: could not compile `rustc_lint` (lib) due to 1 previous error

[rust-bors]

☔ The latest upstream changes (presumably #157689) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.