Don't suggest a binding rename for qualified path patterns#158055
Open
ChronoCoders wants to merge 1 commit into
Open
Don't suggest a binding rename for qualified path patterns#158055ChronoCoders wants to merge 1 commit into
ChronoCoders wants to merge 1 commit into
Conversation
A multi-segment path like `Owner::K` can never be a pattern binding, so the "interpreted as a constant, not a new binding" label and the "introduce a new binding instead" suggestion are misleading there. Only emit them for a lone identifier.
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @tiif (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
Author
|
r? @fmease |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153926.
When a pattern is a qualified path like
Owner::Kwhose type doesn't match the scrutinee, rustc was labelling it "Kis interpreted as an associated constant, not a new binding" and suggestingOwner::other_k. A multi-segment path can never be a binding, so the label is irrelevant and the suggestion is always wrong. This only emits that label and suggestion for a lone identifier now; qualified paths just get the type mismatch.