LLVM 23: Adapt codegen test to moved assume#158067
Open
TimNN wants to merge 1 commit into
Open
Conversation
Collaborator
|
r? @mu001999 rustbot has assigned @mu001999. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
r? dianqk (creator of this test) |
Collaborator
|
|
dianqk
reviewed
Jun 19, 2026
| //@ [new] min-llvm-version: 23 | ||
|
|
||
| // Test for #107681. | ||
| // Make sure we don't create `br` or `select` instructions. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| // CHECK: [[RET:%.*]] = load i32, ptr | ||
| // CHECK-NEXT: assume | ||
| // old-NEXT: assume | ||
| // CHECK-NEXT: ret i32 [[RET]] |
Member
There was a problem hiding this comment.
I think these checks can be changed to something like:
// CHECK: [[INNER:%.*]] = load ptr, ptr %x
// CHECK: [[RET:%.*]] = load i32, ptr [[INNER]]
You can remove or add more CHECK-NOT br or CHECK-NOT select.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't completely sure what the important part of this test is - based on the "Make sure we don't create
brorselectinstructions" comment I assume it's that theloadis followed ~immediately by theret, and that the presence or absence of theassumedoesn't really matter (it's been moved up a few lines to before theload):(If you have a suggestion for how to adapt the test without introducing revisions, I'd be happy to do so).
@rustbot label llvm-main
original CI failure