Skip to content

rustdoc: Fix sidebar heading order#158085

Open
tyilo wants to merge 1 commit into
rust-lang:mainfrom
tyilo:fix-sidebar-heading-order
Open

rustdoc: Fix sidebar heading order#158085
tyilo wants to merge 1 commit into
rust-lang:mainfrom
tyilo:fix-sidebar-heading-order

Conversation

@tyilo

@tyilo tyilo commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Makes sidebar heading order match the order of the headings in the main content.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jun 18, 2026
@rustbot

rustbot commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

r? @lolbinarycat

rustbot has assigned @lolbinarycat.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: rustdoc
  • rustdoc expanded to 9 candidates
  • Random selection from GuillaumeGomez, camelid, lolbinarycat, notriddle

@rust-log-analyzer

This comment has been minimized.

@lolbinarycat

Copy link
Copy Markdown
Contributor

please provide before/after screenshots, as well as your reasoning for why you believe the previous behavior to be incorrect.

@tyilo tyilo force-pushed the fix-sidebar-heading-order branch from 5441dce to 2d79bb6 Compare June 19, 2026 06:48
@tyilo

tyilo commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Before

image

Order in sidebar:

  1. Provided Methods
  2. Implementations on Foreign Types
  3. Dyn Compatibility
  4. Implementors

Order in content:

  1. Provided Methods
  2. Dyn Compatibility
  3. Implementations on Foreign Types
  4. Implementors

After

image

Order in sidebar & content:

  1. Provided Methods
  2. Dyn Compatibility
  3. Implementations on Foreign Types
  4. Implementors

Code used:

#![feature(associated_type_defaults)]

pub trait Foo {
    const REQUIRED: bool;
    const PROVIDED: bool = true;

    type REQUIRED;
    type PROVIDED = ();

    fn required() -> Self;
    fn provided() {}
}

// Foreign impl
impl Foo for () {
    const REQUIRED: bool = true;
    type REQUIRED = ();

    fn required() -> Self {
        ()
    }
}

pub struct Bar;

// Impl
impl Foo for Bar {
    const REQUIRED: bool = true;
    type REQUIRED = ();

    fn required() -> Self {
        Self
    }
}

fn main() {
    println!("Hello, world!");
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants