Skip to content

fix: defer const normalize in coherence mode#158205

Open
cordx56 wants to merge 1 commit into
rust-lang:mainfrom
cordx56:fix/const-coherence
Open

fix: defer const normalize in coherence mode#158205
cordx56 wants to merge 1 commit into
rust-lang:mainfrom
cordx56:fix/const-coherence

Conversation

@cordx56

@cordx56 cordx56 commented Jun 21, 2026

Copy link
Copy Markdown

I'm not confident that this fix is the best and desired in the long term point of view, but I'm confident that this does not do anything unsound.

Fixes #157937, by deferring normalization of associated const, except for anon, in coherence mode.
This fix prevents reporting impls, including associated const, are not overlapping.

@rustbot

rustbot commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

changes to the core type system

cc @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2026
@rustbot

rustbot commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @petrochenkov (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 18 candidates

@lcnr

lcnr commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

r? lcnr

@rustbot rustbot assigned lcnr and unassigned petrochenkov Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: failed to resolve instance for <A<[i8; 1]> as From<A<[i8; 1]>>>::from

4 participants