Skip to content

Remove std::fmt::Display implementation for std::bstr::ByteStr/ByteString#158215

Open
DanielEScherzer wants to merge 2 commits into
rust-lang:mainfrom
DanielEScherzer:no-bytestr-display
Open

Remove std::fmt::Display implementation for std::bstr::ByteStr/ByteString#158215
DanielEScherzer wants to merge 2 commits into
rust-lang:mainfrom
DanielEScherzer:no-bytestr-display

Conversation

@DanielEScherzer

@DanielEScherzer DanielEScherzer commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Part of #134915
r? @BurntSushi

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 21, 2026
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job x86_64-gnu-next-trait-solver-polonius failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    |
help: the trait `fmt::Display` is not implemented for `ByteStr`
   --> library/core/src/bstr/mod.rs:40:1
    |
 40 | pub struct ByteStr(pub [u8]);
    | ^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0277`.
[RUSTC-TIMING] core test:false 18.947
error: could not compile `core` (lib) due to 1 previous error

For more information how to resolve CI failures of this job, visit this link.

@BurntSushi

Copy link
Copy Markdown
Member

I would guess that we will want [u8]::display too, so keeping this functionality around is probably wise.

Note also that this is a suggestion on my part. Idk if there is consensus yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants