jq directives for jsondocck#158269
Conversation
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.
Some changes occurred in src/tools/compiletest cc @jieyouxu These commits modify the If this was unintentional then you should revert the changes before this PR is merged. These commits modify Please ensure that if you've changed the output:
|
|
Failed to set assignee to
|
There was a problem hiding this comment.
Thanks for working on this! This is a really good start.
This should also update the docs in src/doc/rustc-dev-guide/src/rustdoc-internals/rustdoc-json-test-suite.md
Also, I know we don't have them at the moment, but it would be nice to have unit-tests for this. (Grep for jsondoclint for details about how to wire them into the overall build/ci system).
Finally, I can't review/approve this (rust-lang/team#2523), someone still on the rustdoc team will have to.
|
r? @lolbinarycat (Discussed this at all-hands, feel free to re-assign). CC @fmease (Also discussed vague ideas about rustdoc testing) |
|
|
|
Mirrored the jsonpath directives for jq except for Conversions from Conversions from Unfortunately this means that we lose error messages from |
Closes #142479.
Adds
jqdirectives forjsondocck.I decided to add jq instead of replacing jsonpath entirely so that migration could happen incrementally. In theory, it should be possible to replace every jsonpath test case with the new
jqdirectives. Moving forward, this might put more burden on reviewers as test case writers would have the option to use jq or jsonpath or even both. Note that you cannot usejq_setwith jsonpath directives orsetwith jq directives. Diff should be reviewed without whitespace.r? @aDotInTheVoid