autodiff - typtree cleanups#158278
Open
ZuseZ4 wants to merge 2 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
81fe112 to
8698ac6
Compare
Member
Author
|
Ok, the test was failing on main, regardless of the refactoring. Slightly concerning, but I'll fix it along with the logic updates in the follow-up pr. |
oli-obk
reviewed
Jun 23, 2026
oli-obk
reviewed
Jun 23, 2026
oli-obk
requested changes
Jun 23, 2026
8698ac6 to
d9038db
Compare
Member
Author
|
@bors review |
Contributor
|
Unknown command "review". Run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some recent experiments I managed to lower more MIR information to LLVM to help Enzyme compile a test case that was previously failing.
That PR became a little bigger, and we might want to add even more code. To get started I split it out of mod.rs, since that file is already 2.4k loc. In the process, I also fix some checks and deleted
typetree_from_ty_implandtypetree_from_ty_inner, since they don't do much.r? oli-obk
(noticed a regression in a test, marking as draft for now.)