Use .drectve for MSVC DLL exports#158294
Open
AsakuraMizu wants to merge 2 commits into
Open
Conversation
While it would be reasonable to expect the Windows linker to handle linker args in the .drectve section identical to cli arguments, as it turns out exporting weak symbols only works when the /EXPORT is in the .drectve section, not when it is a linker argument or when a .DEF file is used.
Collaborator
|
r? @oli-obk rustbot has assigned @oli-obk. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
bjorn3
reviewed
Jun 23, 2026
bjorn3
reviewed
Jun 23, 2026
b0075d5 to
4051560
Compare
Contributor
Author
|
Updated :) @rustbot ready |
oli-obk
approved these changes
Jun 24, 2026
Contributor
Member
|
Maybe rollup=iffy? Linkage related things tend to be tricky. |
Contributor
|
@bors rollup=iffy reason=windows linker shenanigans |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #142568.
This fixes the i686 MSVC issue mentioned there:
.deffiles accept undecorated names, but.drectve/EXPORTneeds decorated symbol names. The public export name is preserved withEXPORTAS.It's worth noting that EII with defaults now also works on MSVC.