chore(run): Pass through to subprocess.Popen#361
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
=======================================
Coverage 70.22% 70.22%
=======================================
Files 21 21
Lines 1857 1857
=======================================
Hits 1304 1304
Misses 553 553
Continue to review full report at Codecov.
|
f699cee to
9e450cc
Compare
9e450cc to
06e66d6
Compare
fe2ea03 to
709599a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of us migrating to
SubprocessCommand#340 , make existingrun()directly compatible withsubprocess.Popen