Skip to content

URLs: Renaming#417

Merged
tony merged 6 commits into
masterfrom
simplify-urls-try-two
Sep 23, 2022
Merged

URLs: Renaming#417
tony merged 6 commits into
masterfrom
simplify-urls-try-two

Conversation

@tony

@tony tony commented Sep 21, 2022

Copy link
Copy Markdown
Member
  • refactor(url):
    • Matcher -> Rule, MatcherRegistry -> Rules
    • matches -> rule_map
    • default_patterns -> patterns
    • MATCHERS -> RULES

@codecov

codecov Bot commented Sep 21, 2022

Copy link
Copy Markdown

Codecov Report

Merging #417 (a038571) into master (5834604) will not change coverage.
The diff coverage is 87.71%.

@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   61.16%   61.16%           
=======================================
  Files          35       35           
  Lines        2758     2758           
  Branches      662      662           
=======================================
  Hits         1687     1687           
  Misses        642      642           
  Partials      429      429           
Impacted Files Coverage Δ
src/libvcs/url/base.py 83.33% <72.72%> (ø)
src/libvcs/url/hg.py 93.87% <81.81%> (ø)
src/libvcs/url/svn.py 89.79% <81.81%> (ø)
src/libvcs/url/git.py 98.73% <100.00%> (ø)
tests/url/test_git.py 100.00% <100.00%> (ø)
tests/url/test_hg.py 100.00% <100.00%> (ø)
tests/url/test_svn.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony force-pushed the simplify-urls-try-two branch from 3f6863d to 3cda1ad Compare September 21, 2022 10:57
@tony

tony commented Sep 21, 2022

Copy link
Copy Markdown
Member Author

This is just renaming

I had this open at 6AM / while waking up and never merged it, but do this after work:

URLs: Rename match to rule (#417)

  • Matcher -> Rule, MatcherRegistry -> Rules
  • matches -> rule_map
  • default_patterns -> patterns
  • MATCHERS -> RULES

@tony tony force-pushed the simplify-urls-try-two branch from 81f04d0 to a038571 Compare September 22, 2022 02:40
@tony tony merged commit 853ccb7 into master Sep 23, 2022
@tony tony deleted the simplify-urls-try-two branch September 23, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant