sync(git): Fix issue with @ in chomp_protocol()#446
Merged
Conversation
chomp_protocol()
This would cause Git SSH URLs to be chopped off in set_remote() See also: #431
e3fe280 to
9c69417
Compare
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
==========================================
+ Coverage 62.47% 62.50% +0.02%
==========================================
Files 39 39
Lines 3438 3435 -3
Branches 928 927 -1
==========================================
- Hits 2148 2147 -1
+ Misses 773 772 -1
+ Partials 517 516 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also: