Fix menu ordering on item update#502
Closed
nateinaction wants to merge 2 commits into
Closed
Conversation
a55a71b to
d87a666
Compare
Author
|
This is close but we need slightly more complex logic for reordering. Still seeing odd ordering issues on top of problems when gaps exist in menu item order. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #463
This PR reorders menu items when using
wp menu item updatecommand with the--positionflagPrevious behavior is described in #463
New behavior:
While this fix works, it utilizes
reorder_menu_items()which I believe is potentially error prone in situations where there are gaps in menu item ordering. Menu ordering gaps can be introduced using the samewp menu item updatecommand and can cause abnormal behavior when reordering position. I'm curious about the maintainer's interest in enforcing menu item ordering without allowing gaps?Another potential bug could be the
positionshown when listing the menu does not match themenu_ordercolumn in thepoststable. By not displaying the exactmenu_ordervalue we can cause confusion like I had when investigating this issue.