changeset:   102446:ad3762227655
branch:      3.5
parent:      102442:a6be689eacf8
user:        Martin Panter <vadmium+py@gmail.com>
date:        Mon Jul 25 02:30:05 2016 +0000
files:       Misc/NEWS Objects/abstract.c
description:
Issue #27581: Don’t rely on overflow wrapping in PySequence_Tuple()

Patch by Xiang Zhang.


diff -r a6be689eacf8 -r ad3762227655 Misc/NEWS
--- a/Misc/NEWS	Mon Jul 25 04:55:51 2016 +0300
+++ b/Misc/NEWS	Mon Jul 25 02:30:05 2016 +0000
@@ -25,6 +25,9 @@
 - Issue #27507: Add integer overflow check in bytearray.extend().  Patch by
   Xiang Zhang.
 
+- Issue #27581: Don't rely on wrapping for overflow check in
+  PySequence_Tuple().  Patch by Xiang Zhang.
+
 - Issue #27443: __length_hint__() of bytearray iterators no longer return a
   negative integer for a resized bytearray.
 
diff -r a6be689eacf8 -r ad3762227655 Objects/abstract.c
--- a/Objects/abstract.c	Mon Jul 25 04:55:51 2016 +0300
+++ b/Objects/abstract.c	Mon Jul 25 02:30:05 2016 +0000
@@ -1724,21 +1724,22 @@
             break;
         }
         if (j >= n) {
-            Py_ssize_t oldn = n;
+            size_t newn = (size_t)n;
             /* The over-allocation strategy can grow a bit faster
                than for lists because unlike lists the
                over-allocation isn't permanent -- we reclaim
                the excess before the end of this routine.
                So, grow by ten and then add 25%.
             */
-            n += 10;
-            n += n >> 2;
-            if (n < oldn) {
+            newn += 10u;
+            newn += newn >> 2;
+            if (newn > PY_SSIZE_T_MAX) {
                 /* Check for overflow */
                 PyErr_NoMemory();
                 Py_DECREF(item);
                 goto Fail;
             }
+            n = (Py_ssize_t)newn;
             if (_PyTuple_Resize(&result, n) != 0) {
                 Py_DECREF(item);
                 goto Fail;