Skip to content

fix angular release#6468

Merged
TkDodo merged 7 commits into
mainfrom
feature/fix-angular-release
Dec 1, 2023
Merged

fix angular release#6468
TkDodo merged 7 commits into
mainfrom
feature/fix-angular-release

Conversation

@TkDodo

@TkDodo TkDodo commented Dec 1, 2023

Copy link
Copy Markdown
Collaborator

we cannot publish out of the build directory because pnpm doesn't see it as a workspace, so it won't replace workspace dependencies. To fix this, we:

  • make the publish script point to the root directory (config.js)
  • make sure our top-level package.json has types and exports and that they point to ./build
  • make sure to remove the build/package.json after the build script ran

we cannot publish out of the build directory because pnpm doesn't see it as a workspace, so it won't replace workspace dependencies. To fix this, we:

- make the publish script point to the root directory (config.js)
- make sure our top-level package.json has types and exports and that they point to ./build
- make sure to remove the build/package.json after the build script ran
@vercel

vercel Bot commented Dec 1, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Dec 1, 2023 3:22pm

@nx-cloud

nx-cloud Bot commented Dec 1, 2023

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4424a76. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codesandbox-ci

codesandbox-ci Bot commented Dec 1, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4424a76:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@TkDodo TkDodo merged commit 4e8a6c5 into main Dec 1, 2023
@TkDodo TkDodo deleted the feature/fix-angular-release branch December 1, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant