fix(tests): add type tests for useQueries#6471
Conversation
Creating new useQueries type tests in react-query and vue-query and fixing a couple of type bugs.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7c2e6dc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7c2e6dc:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #6471 +/- ##
==========================================
+ Coverage 87.83% 93.50% +5.66%
==========================================
Files 87 20 -67
Lines 2926 277 -2649
Branches 803 68 -735
==========================================
- Hits 2570 259 -2311
+ Misses 297 16 -281
+ Partials 59 2 -57 ☔ View full report in Codecov by Sentry. |
|
Writing the tests flagged up some typing issues. In both vue-query and react-query, | undefined was always returned, even if initialData was set. In vue-query, it didn't support passing queryOptions through. |
|
yeah we never got to the point where initialData removed undefined for userQueries as well ❤️ |
Creating new useQueries type tests in react-query and vue-query and fixing a couple of type bugs.
discussed in #6442