Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: canonical/data-platform-workflows
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3
Choose a base ref
...
head repository: canonical/data-platform-workflows
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4
Choose a head ref
  • 11 commits
  • 33 files changed
  • 1 contributor

Commits on Jul 28, 2023

  1. breaking(build_charms_with_cache.yaml): Use subset of poetry.lock in …

    …cache key (#69)
    
    `poetry.lock` contains charm dependencies and non-charm dependencies.
    Only when charm dependencies change we need to create a new cache.
    
    This PR replaces (in the cache key) `poetry.lock` with
    `requirements-last-build.txt` which is generated by a tox `pack-wrapper`
    environment.
    
    `requirements-last-build.txt` is a misleading name in this context.
    Normally, it would be generated after a `charmcraft pack` by running
    `tox run -e build`. However, when we run `tox run -e pack-wrapper`, the
    `charmcraft pack` step is skipped—so there was no "last build".
    
    `requirements-last-build.txt` is identical to the `requirements.txt`
    file that would have been used during `charmcraft pack`.
    
    ---
    
    This PR is only a breaking change for charms that have implemented a
    `build` tox environment which was added in #59. No dependent
    repositories have implemented this, so this change will not break any
    repositories. It will only break this PR:
    canonical/mysql-operator#192
    carlcsaposs-canonical authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    63586d3 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. compatible: Add pytest-operator plugin for test grouping (#65)

    Will be used in future integration test reusable workflow
    carlcsaposs-canonical authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    33f562c View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Configuration menu
    Copy the full SHA
    8bbc3cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6a59e1d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bd0079a View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. patch(pytest_plugins/pytest_operator_groups): Run modifyitems hook la…

    …st (#73)
    
    pytest_collection_modifyitems hook in plugin.py should run after tests
    are deselected with `-m` (e.g. `pytest -m "not unstable"`) so that a
    GitHub runner is not provisioned for an empty group
    carlcsaposs-canonical authored Aug 4, 2023
    Configuration menu
    Copy the full SHA
    7e7d17d View commit details
    Browse the repository at this point in the history
  2. patch(build_charms_with_cache.yaml): Disable charmcraft snap refresh …

    …in cached LXC containers (#74)
    
    And add charmcraft snap revision to cache key
    
    Potential workaround for
    canonical/charmcraft#1202
    carlcsaposs-canonical authored Aug 4, 2023
    Configuration menu
    Copy the full SHA
    d56b5b9 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. compatible: Add integration_test_charm.yaml (#75)

    Supports lxd; microk8s support planned in the future
    carlcsaposs-canonical authored Aug 7, 2023
    Configuration menu
    Copy the full SHA
    2e84a21 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Configuration menu
    Copy the full SHA
    59bb0e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. patch(integration-test-charm.yaml): Pass proxy env vars (e.g. `HTTPS_…

    …PROXY`) to Juju machines (#77)
    
    Fixes backup integration tests on self-hosted runners
    carlcsaposs-canonical authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    4c052b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7a5223a View commit details
    Browse the repository at this point in the history
Loading