Skip to content

fix: boolean numeric short option#294

Merged
bcoe merged 4 commits into
yargs:masterfrom
QmarkC:283-fix-boolean-numeric-short-option
Aug 5, 2020
Merged

fix: boolean numeric short option#294
bcoe merged 4 commits into
yargs:masterfrom
QmarkC:283-fix-boolean-numeric-short-option

Conversation

@QmarkC

@QmarkC QmarkC commented Jul 20, 2020

Copy link
Copy Markdown
Contributor

Fixes #283 by adding a check to see if next option is a boolean alias.

@QmarkC QmarkC changed the title fix: boolean numeric short option (#283) fix: boolean numeric short option Jul 20, 2020
@QmarkC

QmarkC commented Aug 3, 2020

Copy link
Copy Markdown
Contributor Author

@bcoe or @mleguen can one of you review this when you have the chance?

@mleguen mleguen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @QmarkC !

@bcoe

bcoe commented Aug 4, 2020

Copy link
Copy Markdown
Member

@QmarkC bother you to rebase now that I've landed the ESM refactor?

@bcoe bcoe merged commit f600082 into yargs:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: different result for -x1 and -1x when -x and -1 are both booleans

3 participants