Duplicating Query Block can result in duplicate Query IDs

[peterwilsoncc]

Description

Duplicating the Query Block can result in duplicate query IDs resulting in unexpected enhanced pagination behaviour.

Step-by-step reproduction instructions

1. Install WP Trunk ( WordPress/wordpress-develop@64bfb23 )
2. Do not enabled Gutenberg
3. Generate some posts via wp cli, wp post generate
4. Go to the site editor
5. Edit the home page
6. Remove all group blocks except for the group containing Query block (this is to make it easier to see the effect while testing)
7. Select the query block
8. Ensure "Force page reload" is turned off
9. Add a pagination block if required
10. Select the group block above the query block (ie, the group containing the heading "Watch, Read, Listen")
11. Duplicate the group
12. In the duplicated group, modify the query so it doesn't inherit from the main query
13. Save the template
14. Visit the front end of the site
15. Click next page on either query block
16. Observe the page changes on both blocks

Screenshots, screen recording, code snippet

No response

Environment info

• WordPress Trunk ( WordPress/wordpress-develop@64bfb23 )
• Gutenberg Plugin: Deactivated

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[Mamaduka]

This is a known issue with internal attributes - #29693. Here're two ongoing explorations: #34750 and #38643.

[gziolo]

This is a known issue with internal attributes - #29693. Here're two ongoing explorations: #34750 and #38643.

There is a detailed overview of the current limitations of block attributes provided by @noisysocks in #49466. There are multiple ways we could address it, but all the options should have working prototypes so we would need to finally make a decision what is the best way path forward and incorporate them with the Query block to fix the issue.

[ryanwelcher]

Wanted to bump this as I just received a report on my Advanced Query Loop plugin for this - ryanwelcher/advanced-query-loop#42

[archiveofwork]

I was about to post about this same issue

[skorasaurus]

This still occurs however I've worked around this by manually changing the queryid of one of the loops in the code editor.

[albanyacademy]

Wanted to bump this as I just received a report on my Advanced Query Loop plugin for this - ryanwelcher/advanced-query-loop#42

for our plugin we just expose the query id:

[roborourke]

I've worked around this for now in our query loop extensions plugin here using a HOC:

https://github.com/humanmade/hm-query-loop/blob/main/src/index.js#L58-L105

Also has a backup approach to capture any dupes server side too:

https://github.com/humanmade/hm-query-loop/blob/main/hm-query-loop.php#L181-L267