Exclude internal PHPStan stubs from distribution archives#6329
Merged
Conversation
2 tasks
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incomplete global wpdb stub in PHPStan
Exclude internal PHPStan stubs from distribution archives
Jun 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents WP-CLI’s internal PHPStan helper stubs (notably the partial wpdb stub) from being included in distribution archives, reducing the risk of downstream PHPStan false-positives when scanning installed vendor trees.
Changes:
- Added
export-ignorerules forutils/phpstan/so it’s excluded from generated distribution archives. - Leaves runtime behavior unchanged while keeping internal analysis-only files out of consumer installs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WP-CLI ships
utils/phpstan/scan-files.php, which declares a partial globalwpdbstub. When downstream PHPStan runs scan installed vendor trees, that stub can shadow fuller WordPress definitions and trigger false positives such asCall to an undefined method wpdb::get_col().What changed
utils/phpstan/directory asexport-ignorein.gitattributes.Why this addresses the issue
wpdbstub.Archive rule
Effect on consumers
This no longer picks up WP-CLI’s incomplete
wpdbstub fromutils/phpstan/scan-files.phpin distributed installs.