Skip to content

EditedMediaItem.setFrameRate cap stops working after a slower part of a variable-speed SpeedProvider #3539

Open

Description

@Mait76

Version

Media3 1.11.0

More version details

Reproduced on 1.11.0 (CompositionPlayer preview and Transformer export). The same code is in main as of 2026-11-12 (read, not run): SequenceRenderersFactory.TargetFrameRateHelper.onOutputFrameRendered and ExoAssetLoaderVideoRenderer.feedConsumerFromDecoder.

Devices that reproduce the issue

Samsung Galaxy S20 (Android 13), Samsung Galaxy S8+ (Android 9)

Devices that do not reproduce the issue

None known

Reproducible in the demo app?

Not tested

Reproduction steps

  1. Create an EditedMediaItem from a 30 fps clip, clipped to its first 8 s, with setSpeed(...) using a variable SpeedProvider: 1x from 0 s, 0.5x from 2 s, 2x from 4 s (original media time), and setFrameRate(30).
  2. Play it in CompositionPlayer and export it with Transformer.
  3. Count the frames the item delivers per second of output time (for example with a pass-through MatrixTransformation in the item's video effects).

Expected result

At most 30 frames per second in every part: 30, 30, 15, 15, 15, 15, 30, 30.

Actual result

30, 30, 15, 15, 15, 15, 60, 60: the 2x part is not capped, in preview and export. With the order reversed (2x first, then 0.5x) the cap works. A short slow part (0.4 s of original time at 0.5x) lets about 0.4 s of the following 2x part through uncapped (24, 36 frames in those seconds).

Cause: the same logic is in SequenceRenderersFactory.TargetFrameRateHelper.onOutputFrameRendered (CompositionPlayer) and ExoAssetLoaderVideoRenderer.feedConsumerFromDecoder (Transformer): after each rendered frame the next expected timestamp is advanced by one step (next + delta), not from the frame's own timestamp. While frames are further apart than one step (a slowed part), the expected timestamp falls behind, so in a following faster part no frame is dropped until it catches up.

Fix we use (patched 1.11.0, measured on the S20, the S8+ and a Galaxy S23 on Android 17): after advancing by one step, if the expected timestamp is still at or before the rendered frame's timestamp, advance it in whole steps until it is past that frame:

nextExpectedUs += deltaUs;
if (nextExpectedUs <= presentationTimeUs) {
  long behindUs = presentationTimeUs - nextExpectedUs;
  nextExpectedUs += (behindUs / deltaUs + 1) * deltaUs;
}

Steady speeds keep the same grid and drop the same frames as before (measured at 2x and 4x); the ramp above gives 30, 30, 15, 15, 15, 15, 30, 30 in preview and export.

Media

Not applicable: any 30 fps H.264 clip reproduces it (ours: 1080x1920, 15.9 s).

Bug Report

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions