Repository navigation
Update example assets - #4546
Merged
Merged
Conversation
diegoteran
previously approved these changes
Oct 27, 2023
Contributor
Author
|
This is super strange - the CI is 404ing on BrainStem.glb and Triangle.gltf, though they work fine locally, and all the other glTF-Sample-Assets work fine in the other tests on the CI. @bhouston do you have any thoughts? |
elalish
commented
Oct 27, 2023
| steps: | ||
| - uses: actions/checkout@v3 | ||
| with: | ||
| submodules: true |
Contributor
Author
There was a problem hiding this comment.
Ah, I think this is what I was missing.
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
* updates for new samples repo * fix test run for external contributors * avoid duplicate CI runs * add submodules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bhouston Our tests were broken because the Sample-Models hadn't been updated to Sample-Assets yet. You probably didn't noticed because like me, you hadn't deleted the Sample-Models directory and the unit tests weren't running on the CI for your PRs. I think I've fixed that here too - we'll see when you pull it into your open PRs.