Skip to content

Update example assets - #4546

Merged
elalish merged 4 commits into
masterfrom
updateExampleAssets
Oct 27, 2023
Merged

elalish merged 4 commits into
masterfrom
updateExampleAssets

Conversation

@elalish

@elalish elalish commented Oct 27, 2023

Copy link
Copy Markdown
Contributor

@bhouston Our tests were broken because the Sample-Models hadn't been updated to Sample-Assets yet. You probably didn't noticed because like me, you hadn't deleted the Sample-Models directory and the unit tests weren't running on the CI for your PRs. I think I've fixed that here too - we'll see when you pull it into your open PRs.

@elalish elalish self-assigned this Oct 27, 2023
@elalish
elalish requested a review from diegoteran October 27, 2023 18:03
diegoteran
diegoteran previously approved these changes Oct 27, 2023
@elalish

elalish commented Oct 27, 2023

Copy link
Copy Markdown
Contributor Author

This is super strange - the CI is 404ing on BrainStem.glb and Triangle.gltf, though they work fine locally, and all the other glTF-Sample-Assets work fine in the other tests on the CI. @bhouston do you have any thoughts?

steps:
- uses: actions/checkout@v3
with:
submodules: true

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think this is what I was missing.

@elalish
elalish requested a review from diegoteran October 27, 2023 19:08

@diegoteran diegoteran left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@elalish
elalish merged commit 9fbe7a0 into master Oct 27, 2023
@elalish
elalish deleted the updateExampleAssets branch October 27, 2023 19:09
JL-Vidinoti pushed a commit to vidinoti/model-viewer that referenced this pull request Apr 22, 2024
* updates for new samples repo

* fix test run for external contributors

* avoid duplicate CI runs

* add submodules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants