Skip to content

A11y implementation for WCAG compliance. - #4715

Merged
elalish merged 4 commits into
google:masterfrom
cybmiper:wcag-improvements
Apr 3, 2024
Merged

elalish merged 4 commits into
google:masterfrom
cybmiper:wcag-improvements

Conversation

@cybmiper

Copy link
Copy Markdown
Contributor

No description provided.

@Mazas

Mazas commented Mar 14, 2024

Copy link
Copy Markdown

Some context for the PR. We have talked about this trough email before. The current implementation has accessibility support; however, it is not localized. We would like to bring some attention to it and work towards making sure it follows the standards required by the EU.

@elalish elalish left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks! Just a few details to clear up. Also, this probably isn't a Draft PR anymore, right?

Comment thread packages/modelviewer.dev/data/docs.json Resolved
@cybmiper
cybmiper marked this pull request as ready for review April 2, 2024 14:08
@cybmiper
cybmiper requested a review from elalish April 2, 2024 14:09

@elalish elalish left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent - thank you for the tests!

@elalish
elalish merged commit b8df887 into google:master Apr 3, 2024
JL-Vidinoti pushed a commit to vidinoti/model-viewer that referenced this pull request Apr 22, 2024
* A11y implementation for WCAG compliance.

* Readd in controls, merge examples into loading and add docs.

* Added a language switch in example page.

* Added tests in control for a11y and minor review fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants