Skip to content

fix: keep focused hotspots visible - #5199

Merged
diegoteran merged 1 commit into
google:masterfrom
minwookshin:fix-hotspot-focus-visibility
Oct 6, 2026
Merged

diegoteran merged 1 commit into
google:masterfrom
minwookshin:fix-hotspot-focus-visibility

Conversation

@minwookshin

Copy link
Copy Markdown
Contributor

Reference Issue

Fixes #5192.

Keep an obscured hotspot at its normal opacity while it or a child control has focus. The existing minimum opacity returns on blur, and custom minimum/maximum opacity values are preserved.

The CSS condition lives on the annotation wrapper so descendant focus also works in WebKit. Added four regression cases covering direct/child focus, default/custom opacity, and blur; all four fail before the fix.

Validation: annotation, Hotspot, and controls browser suites passed in Chromium, Firefox, and WebKit (69 passed and 7 pre-existing skips per browser). npm run build -w @google/model-viewer passed. The repository excludes this package from ESLint; forcing it reports existing violations outside the added tests.

@diegoteran diegoteran left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@diegoteran
diegoteran merged commit 0ebfe46 into google:master Oct 6, 2026
8 checks passed
diegoteran added a commit that referenced this pull request Nov 13, 2026
* fix(editor): resolve uploaded glTF resource paths

* fix: restore viewer state after Quick Look export failure (#5198)

* fix: preserve hotspot visibility while focused (#5199)

* fix: omit horizontal anchoring for Quick Look wall exports (#5201)

Adopt the wall-export options from the follow-up to #4030 and test
the USDZ metadata, model transforms and viewer rotation.

Co-authored-by: Vincent Fretin <112249+vincentfretin@users.noreply.github.com>

* test: remove boom_2_.glb from prepareUSDZ placement test (#5204)

* v4.4.0 (#5205)

* ci: migrate @google/model-viewer npm publishing from Wombat to OSS Exit Gate (#5207)

* ci: pin unit tests to a supported Playwright runner

* ci: satisfy required workflow action and permission checks

* fix(ci): fix OSS Exit Gate registry auth and manifest namespace (#5213)

* fix(ci): fix OSS Exit Gate registry auth and manifest namespace

* chore(ci): bump playwright to 1.64.1 for ubuntu-26.04 support

* fix: drop the redundant SVG mask so removed elements can be collected (#5208)

The interaction prompt icon in every shadow root referenced a mask with url(#B), which makes Chromium keep the shadow tree of a removed element alive.

Signed-off-by: Arthur031221 <124417490+Arthur031221@users.noreply.github.com>

* fix(editor): resolve uploaded glTF resource paths

* ci: pin unit tests to a supported Playwright runner

* ci: satisfy required workflow action and permission checks

* chore(ci): revert unit-tests workflow changes

---------

Signed-off-by: Arthur031221 <124417490+Arthur031221@users.noreply.github.com>
Co-authored-by: Chi-Wei Lee <levi74108520963@gmail.com>
Co-authored-by: Vincent Fretin <112249+vincentfretin@users.noreply.github.com>
Co-authored-by: Diego Teran <dteran@google.com>
Co-authored-by: alonsopf89 <alonsopf@gmail.com>
Co-authored-by: Arthur <124417490+Arthur031221@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potential focus visibility issue in annotations/hotspots

2 participants