You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Javascript's number overflow for timescale 10000000 (PlayReady/SmoothStreaming default) #1667
changed the title [-]Javascript's number overflow for timescale 1000000 (PlayReady/SmoothStreaming default)[/-][+]Javascript's number overflow for timescale 10000000 (PlayReady/SmoothStreaming default)[/+]on Nov 15, 2018
I'm sorry, but we are not going to add a BigInteger library to support extremely large timescales. This additional dependency would not be optional and would increase the size of Shaka Player by ~20%.
I know this is probably disappointing to hear, but we won't support content that creates Numbers too large to be exact integers in JavaScript (2^53). Please fix your timescale to something more reasonable.
Activity
[-]Javascript's number overflow for timescale 1000000 (PlayReady/SmoothStreaming default)[/-][+]Javascript's number overflow for timescale 10000000 (PlayReady/SmoothStreaming default)[/+]Fix: shaka-project#1667 Javascript's number overflow for timescale 10…
agelun commentedon Nov 15, 2018
Example fix based on https://github.com/peterolson/BigInteger.js attached.
joeyparrish commentedon Nov 15, 2018
I'm sorry, but we are not going to add a BigInteger library to support extremely large timescales. This additional dependency would not be optional and would increase the size of Shaka Player by ~20%.
I know this is probably disappointing to hear, but we won't support content that creates Numbers too large to be exact integers in JavaScript (2^53). Please fix your timescale to something more reasonable.
joeyparrish commentedon Nov 15, 2018
We will update our README and FAQ to document this. I apologize for the inconvenience.
chrisfillmore commentedon Nov 22, 2018
This may be interesting to all parties: https://github.com/tc39/proposal-bigint