Skip to content

Support Home and End keys in tabs - #38498

Merged
XhmikosR merged 11 commits into
twbs:mainfrom
kyletsang:tab-home-end-key
Jul 23, 2023
Merged

XhmikosR merged 11 commits into
twbs:mainfrom
kyletsang:tab-home-end-key

Conversation

@kyletsang

@kyletsang kyletsang commented Apr 23, 2023 •

Copy link
Copy Markdown
Contributor

Description

Adds support for Home and End keys in JS tabs.

Motivation & Context

Better tab accessibility support

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #38471

@kyletsang
kyletsang requested a review from a team as a code owner April 23, 2023 04:46
@kyletsang
kyletsang marked this pull request as draft April 23, 2023 04:53
@XhmikosR
XhmikosR removed the request for review from a team April 23, 2023 05:27
@kyletsang
kyletsang marked this pull request as ready for review April 23, 2023 05:29
@GeoSot

GeoSot commented Apr 29, 2023

Copy link
Copy Markdown
Member

@patrickhlauke is it a navigation behavior we should support or not?

@GeoSot GeoSot added js JavaScript or TypeScript sources and plugins v5 v5, the v5-dev branch labels Apr 29, 2023
@patrickhlauke

Copy link
Copy Markdown
Member

@GeoSot it's not essential, but a nice-to-have https://www.w3.org/WAI/ARIA/apg/patterns/tabs/#keyboardinteraction

Comment thread js/tests/unit/tab.spec.js Resolved
@julien-deramond julien-deramond added the accessibility Keyboard, screen readers, contrast, ARIA label May 10, 2023
@mdo

mdo commented Jun 1, 2023

Copy link
Copy Markdown
Member

@GeoSot @XhmikosR Is this good to go?

@GeoSot
GeoSot self-requested a review June 1, 2023 15:58
@GeoSot

GeoSot commented Jun 8, 2023

Copy link
Copy Markdown
Member

Seems fine to me 👍

@XhmikosR
XhmikosR merged commit d45cc7e into twbs:main Jul 23, 2023
@kyletsang
kyletsang deleted the tab-home-end-key branch July 24, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility Keyboard, screen readers, contrast, ARIA js JavaScript or TypeScript sources and plugins v5 v5, the v5-dev branch

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Improve tab navigations accessibility with Home and End keys

6 participants