Skip to content

Update vite.md - #39592

Merged
julien-deramond merged 4 commits into
twbs:mainfrom
rmx90210:patch-2
Feb 13, 2024
Merged

julien-deramond merged 4 commits into
twbs:mainfrom
rmx90210:patch-2

Conversation

@rmx90210

@rmx90210 rmx90210 commented Jan 21, 2024 •

Copy link
Copy Markdown
Contributor

Description

A quick commit to fix a few small typos/style issues in the Vite tutorial.

Motivation & Context

Improves style and readability in the Vite docs.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Fix some minor style issues in Vite tutorial
@louismaximepiton louismaximepiton added docs Documentation site and its content v5 v5, the v5-dev branch labels Jan 22, 2024
@julien-deramond

julien-deramond commented Jan 30, 2024 •

Copy link
Copy Markdown
Member

Thanks for the PR @rbrtmrtn I'll let our native English speakers confirm that this fix is correct (ping @mdo or @patrickhlauke) :)
However, if we merge it, the exact same modifications should be applied to parcel.md and webpack.md for consistency; they use the same sentences.

@mdo mdo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. @rbrtmrtn Can you update the other guides too?

@julien-deramond
julien-deramond self-requested a review February 13, 2024 18:26

@julien-deramond julien-deramond left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I applied the same modifications to the Parcel and Webpack guides via bd5cf86.

@julien-deramond
julien-deramond merged commit cb7467b into twbs:main Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation site and its content v5 v5, the v5-dev branch

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants