Skip to content

Docs: minor accessibility improvements for Examples - #40620

Merged
julien-deramond merged 2 commits into
twbs:mainfrom
coliff:dev/coliff/docs-examples-a11y-improvements
Jul 19, 2024
Merged

julien-deramond merged 2 commits into
twbs:mainfrom
coliff:dev/coliff/docs-examples-a11y-improvements

Conversation

@coliff

@coliff coliff commented Jul 10, 2024 •

Copy link
Copy Markdown
Contributor

Description

  • no need for role="document" on modals (was removed from Bootstrap a while ago)
  • use type="email" for email input
  • Add aria-labels for previous month and next month buttons on date picker demo

Motivation & Context

Helpful for folks copying and pasting to their own templates to have more accessible code

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

- no need for `role="document"` on modals (was removed from Bootstrap a while ago)
- use `type="email"` for email input
- Add aria-labels for previous month and next month buttons on date picker demo
@julien-deramond julien-deramond added docs Documentation site and its content examples The examples in the docs accessibility Keyboard, screen readers, contrast, ARIA v5 v5, the v5-dev branch labels Jul 10, 2024
@julien-deramond julien-deramond added the enhancement Legacy: use feature label Jul 10, 2024

@louismaximepiton louismaximepiton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM regarding #30755, thanks for the PR 🚀

@julien-deramond
julien-deramond merged commit 74891cb into twbs:main Jul 19, 2024
@coliff
coliff deleted the dev/coliff/docs-examples-a11y-improvements branch July 19, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility Keyboard, screen readers, contrast, ARIA docs Documentation site and its content enhancement Legacy: use feature examples The examples in the docs v5 v5, the v5-dev branch

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants