Skip to content

Mention npm install and npm run dist in CONTRIBUTING.md - #41340

Merged
julien-deramond merged 4 commits into
mainfrom
contributing-npm-1
Apr 7, 2025
Merged

julien-deramond merged 4 commits into
mainfrom
contributing-npm-1

Conversation

@mdo

@mdo mdo commented Apr 3, 2025 •

Copy link
Copy Markdown
Member

Much simpler approach than #41333. Fixes #41209.

@mdo mdo added the meta The repository itself: templates, guidelines, config label Apr 3, 2025
@mdo mdo mentioned this pull request Apr 3, 2025
5 of 10 tasks
@mdo mdo changed the title Update CONTRIBUTING.md Mention npm install and npm run dist in CONTRIBUTING.md Apr 3, 2025
@mdo mdo added this to v5.3.5 Apr 3, 2025
@github-project-automation github-project-automation Bot moved this to To do in v5.3.5 Apr 3, 2025

@julien-deramond julien-deramond left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modifications sound nice, I've just added a comment to avoid having dist and js/dist files in the PRs.

Comment thread .github/CONTRIBUTING.md Resolved
@julien-deramond julien-deramond removed this from v5.3.5 Apr 4, 2025
@mdo
mdo force-pushed the contributing-npm-1 branch from d833201 to 3ce9cec Compare April 6, 2025 19:47
@julien-deramond
julien-deramond self-requested a review April 7, 2025 17:40
@julien-deramond
julien-deramond merged commit 33bb991 into main Apr 7, 2025
@julien-deramond
julien-deramond deleted the contributing-npm-1 branch April 7, 2025 17:44
@julien-deramond julien-deramond moved this to Done in v5.3.6 Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta The repository itself: templates, guidelines, config

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Add npm install step to contribution guide in pull request section

2 participants