Skip to content

#41690: [docs] Tables doc - Variants code examples miss table class - #41691

Merged
julien-deramond merged 2 commits into
twbs:mainfrom
stefan-korn:twbs-bs-41690-table-doc
Sep 6, 2025
Merged

julien-deramond merged 2 commits into
twbs:mainfrom
stefan-korn:twbs-bs-41690-table-doc

Conversation

@stefan-korn

@stefan-korn stefan-korn commented Aug 27, 2025 •

Copy link
Copy Markdown
Contributor

Description

fixes #41690

Motivation & Context

fixes #41690

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@julien-deramond julien-deramond added docs Documentation site and its content v5 v5, the v5-dev branch labels Sep 6, 2025
@julien-deramond
julien-deramond self-requested a review September 6, 2025 20:21

@julien-deramond julien-deramond left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was likely just meant as an example of where to add the class, but I agree it’s confusing. Let’s add the .table class as you suggest. 👌
Thanks for the PR @stefan-korn 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation site and its content v5 v5, the v5-dev branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] Tables doc - Variants code examples miss table class

2 participants