Skip to content

docs: Heroes example Replace unstyled checkbox with form-check - #42406

Merged
mdo merged 1 commit into
twbs:mainfrom
coliff:dev/coliff/heroes-example-checkbox-css
May 15, 2026
Merged

mdo merged 1 commit into
twbs:mainfrom
coliff:dev/coliff/heroes-example-checkbox-css

Conversation

@coliff

@coliff coliff commented May 11, 2026 •

Copy link
Copy Markdown
Contributor

Description

Update the Heroes example Remember me checkbox to use Bootstrap 5 form-check markup. Change container class to form-check mb-3, add form-check-input on the input with an id and form-check-label referencing that id. This improves Bootstrap compatibility and accessibility.

Motivation & Context

Nicer style

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Copilot AI review requested due to automatic review settings May 11, 2026 02:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Heroes example sign-up form to use Bootstrap 5 form-check markup for the “Remember me” checkbox, improving styling consistency and label/input association.

Changes:

  • Replaced legacy .checkbox markup with .form-check structure.
  • Added form-check-input/form-check-label classes and linked the label via for/id.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Update the Heroes example Remember me checkbox to use Bootstrap 5 form-check markup. Change container class to `form-check mb-3`, add `form-check-input` on the input with an `id` and `form-check-label` referencing that id. This improves Bootstrap compatibility and accessibility.
@coliff
coliff force-pushed the dev/coliff/heroes-example-checkbox-css branch from 92eca60 to f290035 Compare May 11, 2026 06:19
@mdo mdo added css Sass sources or compiled CSS v6 v6, the main branch labels May 15, 2026
@mdo mdo added this to v6.0.0 May 15, 2026
@github-project-automation github-project-automation Bot moved this to Inbox in v6.0.0 May 15, 2026
@mdo
mdo merged commit d50c38f into twbs:main May 15, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css Sass sources or compiled CSS v6 v6, the main branch

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

3 participants