Repository navigation
Docs: fix popover option types - #42707
Merged
Merged
Conversation
julien-deramond
force-pushed
the
fix-popover-option-types
branch
from
October 27, 2026 05:47
c6b4fba to
3f31f16
Compare
julien-deramond
marked this pull request as ready for review
October 27, 2026 05:47
julien-deramond
approved these changes
Oct 27, 2026
julien-deramond
left a comment
Member
There was a problem hiding this comment.
Thanks! I checked the three rows against js/src/tooltip.js and js/src/popover.js on v5-dev: fallbackPlacements is 'array', offset is '(array|string|function)' and Popover's content is '(null|string|element|function)', so the table now matches the runtime types (and the Tooltip docs, which already list array for both).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the documented types for three popover options.
Motivation & Context
The popover options table had drifted from the JavaScript
DefaultTypedefinitions shared with Tooltip and extended by Popover:Expected: documented option types match the accepted runtime config types.
Actual:
fallbackPlacementsincludedstring,offsetincludednumberand omittedarray, andcontentomittednull.This updates the Popover docs table so those rows match the source types.
Type of changes
Checklist
npm run lint)Live previews
Related issues
None.
Checks
git diff --checknpm exec -- prettier --config site/.prettierrc.json -c site/src/content/docs/components/popovers.mdxnpm run docs-build