Skip to content

Docs: add href to active pagination sizing links - #42709

Merged
julien-deramond merged 2 commits into
twbs:v5-devfrom
Kevinjohn:fix-pagination-sizing-active-links
Oct 11, 2026
Merged

julien-deramond merged 2 commits into
twbs:v5-devfrom
Kevinjohn:fix-pagination-sizing-active-links

Conversation

@Kevinjohn

@Kevinjohn Kevinjohn commented Jul 19, 2026 •

Copy link
Copy Markdown
Contributor

Description

Adds missing href="#" attributes to the active links in the pagination sizing examples.

Motivation & Context

The sizing examples use active <a> elements with aria-current="page", but those anchors lacked href attributes. The page's canonical active example already uses href="#" for the same pattern.

Expected: the active pagination links in sizing examples follow the documented active-link pattern.
Actual: the active pagination links are anchors without href attributes.

This updates the large and small pagination examples to match the active example on the same page.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

None.

Checks

  • git diff --check
  • npm exec -- prettier --config site/.prettierrc.json -c site/src/content/docs/components/pagination.mdx
  • npm run docs-build

@julien-deramond julien-deramond added docs Documentation site and its content v5 v5, the v5-dev branch labels Jul 20, 2026
@julien-deramond julien-deramond added the html Component markup: elements, attributes, structure label Oct 10, 2026
@julien-deramond julien-deramond added the backport-to-v6 Merged on v5, to backport to v6 label Oct 11, 2026
@github-project-automation github-project-automation Bot moved this to Inbox in v6.0.0 Oct 11, 2026
@julien-deramond
julien-deramond marked this pull request as ready for review October 11, 2026 14:35

@julien-deramond julien-deramond left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The same pattern exists on main (v6: three sizing examples in pagination.mdx still have <a class="page-link" aria-current="page">), so I'll backport there the the same fix.

@github-project-automation github-project-automation Bot moved this from Needs review to Ready to merge in v5.4.0 Oct 11, 2026
@julien-deramond
julien-deramond merged commit ccaee4f into twbs:v5-dev Oct 11, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to merge to Done in v5.4.0 Oct 11, 2026
julien-deramond added a commit that referenced this pull request Oct 11, 2026
Co-authored-by: Kevinjohn Gallagher <kevinjohngallagher@hotmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@julien-deramond julien-deramond added backport-done The backport is merged and removed backport-to-v6 Merged on v5, to backport to v6 labels Oct 11, 2026
@julien-deramond julien-deramond removed this from v6.0.0 Oct 11, 2026
@mdo mdo modified the milestone: v6.0.0-alpha.2 Oct 23, 2026
@mdo mdo removed this from v5.4.0 Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-done The backport is merged docs Documentation site and its content html Component markup: elements, attributes, structure v5 v5, the v5-dev branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants