Skip to content

v5: Preserve literal tooltip and popover text from data attributes - #43319

Merged
mdo merged 1 commit into
v5-devfrom
codex/v5-tooltip-text
Nov 9, 2026
Merged

mdo merged 1 commit into
v5-devfrom
codex/v5-tooltip-text

Conversation

@mdo

@mdo mdo commented Nov 7, 2026

Copy link
Copy Markdown
Member

Backports the markup fix from #43113 to v5. Tooltips and popovers now preserve text from data-bs-title and data-bs-content, so 9.90 stays 9.90 and an empty title no longer interrupts initialization.

Explicit JavaScript options still take precedence, and HTML still goes through the existing sanitizer.

Fixes #43090 for v5.

Keep tooltip titles and popover content as written in markup so
decimal strings retain their formatting and empty titles don't throw.

Read the raw attributes before merging explicit options and keep
the existing sanitization and JavaScript option behavior.
@mdo
mdo requested a review from a team as a code owner November 7, 2026 21:36
@netlify

netlify Bot commented Nov 7, 2026

Copy link
Copy Markdown

✅ Deploy Preview for twbs-bootstrap ready!

Name Link
🔨 Latest commit 4aae787
🔍 Latest deploy log https://app.netlify.com/projects/twbs-bootstrap/deploys/6aef99c547b2319bbaf322d3
😎 Deploy Preview https://deploy-preview-43319--twbs-bootstrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@julien-deramond julien-deramond added v5 v5, the v5-dev branch bug Something does not work as documented js JavaScript or TypeScript sources and plugins labels Nov 7, 2026
@mdo
mdo merged commit 132b512 into v5-dev Nov 9, 2026
14 of 15 checks passed
@mdo
mdo deleted the codex/v5-tooltip-text branch November 9, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something does not work as documented js JavaScript or TypeScript sources and plugins v5 v5, the v5-dev branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants