Skip to content

docs: Fix markdown links and PHP code block in client-side navigation compatibility guide#76856

Merged
DAreRodz merged 4 commits into
trunkfrom
copilot/fix-markdown-links-in-callout
Mar 27, 2026
Merged

docs: Fix markdown links and PHP code block in client-side navigation compatibility guide#76856
DAreRodz merged 4 commits into
trunkfrom
copilot/fix-markdown-links-in-callout

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 27, 2026

  • Convert markdown links in callout div to HTML anchors with absolute URLs
  • Fix PHP code block indentation (moved to top level, 4-space indent)
  • Remove [ ] checkboxes from compatibility checklist bullet items

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

… compatibility guide

Agent-Logs-Url: https://github.com/WordPress/gutenberg/sessions/28f79e52-cbc1-43ee-8656-8cb10982dbe7

Co-authored-by: luisherranz <3305402+luisherranz@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix markdown links in callout to render as HTML docs: Fix markdown links inside callout div in client-side navigation compatibility guide Mar 27, 2026
Copilot AI requested a review from luisherranz March 27, 2026 06:42
@luisherranz
Copy link
Copy Markdown
Member

  • The block does not inject <style> or elements dynamically through JavaScript.
  • The block does not modify existing stylesheets at runtime (e.g., via CSSOM APIs).
  • CSS selectors (class names, IDs) are stable across navig...

@copilot, these don't render as checkboxes, so it would be better to remove the md checkbox part.

@luisherranz
Copy link
Copy Markdown
Member

@copilot, there's also a PHP block that's not rendering correctly. It has indentation; maybe it should be deindented.

php
wp_interactivity()->add_client_navigation_support_to_script_module(
'my-plugin/navigation-handler'
);

Copilot AI changed the title docs: Fix markdown links inside callout div in client-side navigation compatibility guide docs: Fix markdown links and PHP code block in client-side navigation compatibility guide Mar 27, 2026
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 27, 2026

@copilot, there's also a PHP block that's not rendering correctly. It has indentation; maybe it should be deindented.

php
...

This was already fixed in b0c9046 — the PHP code block was moved out of the nested list item to the top level, and the tab-indented argument was replaced with 4-space indentation.

@luisherranz
Copy link
Copy Markdown
Member

@copilot, can you remove the markdown checkboxes here?

- [ ] The block does not inject `<style>` or `<link>` elements dynamically through JavaScript.
- [ ] The block does not modify existing stylesheets at runtime (e.g., via CSSOM APIs).
- [ ] CSS selectors (class names, IDs) are stable across navigations — no use of `wp_unique_id()` for selectors.
- [ ] The block uses script modules, not regular `<script>` tags.
- [ ] The block does not import from `window.wp.*` globals — it uses ES module imports instead.
- [ ] The block does not rely on `DOMContentLoaded` or `load` events for initialization — it uses `data-wp-init` instead.
- [ ] If the block needs to sync state or context from the server on each navigation, it uses `getServerState()` or `getServerContext()`.
- [ ] Lists of sibling elements that can change between navigations use `data-wp-key`.
- [ ] The block does not manipulate the DOM using APIs outside the Interactivity API (e.g., `document.createElement`, jQuery).
- [ ] Any HTML that needs to live outside the block's boundaries (e.g., overlays on `<body>`) uses `attachTo` to define its own region.
- [ ] (Optional) The block works correctly with the [experimental full-page client-side navigation](/docs/reference-guides/interactivity-api/core-concepts/client-side-navigation.md#full-page-client-side-navigation-experimental) mode.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 27, 2026

@copilot, can you remove the markdown checkboxes here?

https://github.com/WordPress/gutenberg/blob/b0c9046075d5b780ca550536d38ae644a28f8ea0/docs/reference-guides/interactivity-api...

Done in eebcecc — all [ ] checkboxes have been removed, converting the checklist into a regular bullet list.

@luisherranz luisherranz marked this pull request as ready for review March 27, 2026 08:45
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 27, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @Copilot.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: Copilot.

Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
Co-authored-by: DAreRodz <darerodz@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Copy Markdown
Member

@luisherranz luisherranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @copilot.

@luisherranz luisherranz added [Type] Developer Documentation Documentation for developers [Feature] Interactivity API API to add frontend interactivity to blocks. labels Mar 27, 2026
@github-actions
Copy link
Copy Markdown

Flaky tests detected in eebcecc.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23638227419
📝 Reported issues:

@DAreRodz DAreRodz enabled auto-merge (squash) March 27, 2026 11:36
@DAreRodz DAreRodz merged commit 84879c5 into trunk Mar 27, 2026
49 of 53 checks passed
@DAreRodz DAreRodz deleted the copilot/fix-markdown-links-in-callout branch March 27, 2026 11:37
@github-actions github-actions Bot added this to the Gutenberg 22.9 milestone Mar 27, 2026
adamsilverstein pushed a commit that referenced this pull request Mar 31, 2026
… compatibility guide (#76856)

* Initial plan

* docs: fix markdown links inside callout div in client-side navigation compatibility guide

Agent-Logs-Url: https://github.com/WordPress/gutenberg/sessions/28f79e52-cbc1-43ee-8656-8cb10982dbe7

Co-authored-by: luisherranz <3305402+luisherranz@users.noreply.github.com>

* docs: de-indent PHP code block in client-side navigation compatibility guide

Agent-Logs-Url: https://github.com/WordPress/gutenberg/sessions/7e0bdd17-9f02-47b7-bbd1-720ce9d6a4a5

Co-authored-by: luisherranz <3305402+luisherranz@users.noreply.github.com>

* docs: Remove markdown checkboxes from compatibility checklist

Agent-Logs-Url: https://github.com/WordPress/gutenberg/sessions/f8b73496-7092-4e1f-a617-a2c8bedb83db

Co-authored-by: luisherranz <3305402+luisherranz@users.noreply.github.com>

---------

Unlinked contributors: Copilot.

Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
ObliviousHarmony pushed a commit that referenced this pull request Apr 1, 2026
… compatibility guide (#76856)

* Initial plan

* docs: fix markdown links inside callout div in client-side navigation compatibility guide

Agent-Logs-Url: https://github.com/WordPress/gutenberg/sessions/28f79e52-cbc1-43ee-8656-8cb10982dbe7

Co-authored-by: luisherranz <3305402+luisherranz@users.noreply.github.com>

* docs: de-indent PHP code block in client-side navigation compatibility guide

Agent-Logs-Url: https://github.com/WordPress/gutenberg/sessions/7e0bdd17-9f02-47b7-bbd1-720ce9d6a4a5

Co-authored-by: luisherranz <3305402+luisherranz@users.noreply.github.com>

* docs: Remove markdown checkboxes from compatibility checklist

Agent-Logs-Url: https://github.com/WordPress/gutenberg/sessions/f8b73496-7092-4e1f-a617-a2c8bedb83db

Co-authored-by: luisherranz <3305402+luisherranz@users.noreply.github.com>

---------

Unlinked contributors: Copilot.

Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
adamsilverstein pushed a commit that referenced this pull request Apr 7, 2026
… compatibility guide (#76856)

* Initial plan

* docs: fix markdown links inside callout div in client-side navigation compatibility guide

Agent-Logs-Url: https://github.com/WordPress/gutenberg/sessions/28f79e52-cbc1-43ee-8656-8cb10982dbe7

Co-authored-by: luisherranz <3305402+luisherranz@users.noreply.github.com>

* docs: de-indent PHP code block in client-side navigation compatibility guide

Agent-Logs-Url: https://github.com/WordPress/gutenberg/sessions/7e0bdd17-9f02-47b7-bbd1-720ce9d6a4a5

Co-authored-by: luisherranz <3305402+luisherranz@users.noreply.github.com>

* docs: Remove markdown checkboxes from compatibility checklist

Agent-Logs-Url: https://github.com/WordPress/gutenberg/sessions/f8b73496-7092-4e1f-a617-a2c8bedb83db

Co-authored-by: luisherranz <3305402+luisherranz@users.noreply.github.com>

---------

Unlinked contributors: Copilot.

Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants