Plugins: Hide search form on Favorites tab#11457
Conversation
The plugin search form should not be displayed on the Favorites tab where it is not applicable. This change prevents the search form from rendering when viewing favorite plugins, reducing UI confusion and aligning with expected behavior. Fixes #65026
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @ManishDhorepatil. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
@SergeyBiryukov can you check this 1] Favourite tab after the fixes removed the search bar 
|
Co-authored-by: Weston Ruter <westonruter@gmail.com>
|
@westonruter can you check now? |
Co-authored-by: Shail Mehta <shailmehta25@gmail.com>
|
@shail-mehta can you check now |
|
It looks good to me. Once |
|
@westonruter any update on this |
|
@manishdhorepatil-art The |
|
@westonruter any update is the trunk open now |
|
Nope |
|
@westonruter pls look into this as trunk open now |
Favorites tab✅ The search box is hidden. The 
This branch: 
Recommended tab✅ As expected, no changes to this tab. The 
This branch: 
|
The plugin search form does not apply to the Favorites tab, which instead expects a WordPress.org username to look up a user's favorited plugins. Rendering the term-based search form there was misleading. Update `WP_Plugin_Install_List_Table::views()` to read the global `$tab` and skip `install_search_form()` when the favorites tab is active, while leaving the form in place on the Featured, Popular, and Recommended tabs. Developed in #11457. Props manishxdp, bor0, westonruter, shailu25, sabbir1991. Fixes #65026. git-svn-id: https://develop.svn.wordpress.org/trunk@62448 602fd350-edb4-49c9-b593-d223f7449a82
The plugin search form does not apply to the Favorites tab, which instead expects a WordPress.org username to look up a user's favorited plugins. Rendering the term-based search form there was misleading. Update `WP_Plugin_Install_List_Table::views()` to read the global `$tab` and skip `install_search_form()` when the favorites tab is active, while leaving the form in place on the Featured, Popular, and Recommended tabs. Developed in WordPress/wordpress-develop#11457. Props manishxdp, bor0, westonruter, shailu25, sabbir1991. Fixes #65026. Built from https://develop.svn.wordpress.org/trunk@62448 git-svn-id: http://core.svn.wordpress.org/trunk@61729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The plugin search form should not be displayed on the Favorites tab where it is not applicable. This change prevents the search form from rendering when viewing favorite plugins, reducing UI confusion and aligning with expected behavior.
Fixes #65026
Ticket track -https://core.trac.wordpress.org/ticket/65026
Go to Plugins → Add New
Click Favorites tab
Verify search form is hidden
Click Featured tab
Verify search form is visible
Click Popular tab
3.Verify search form is visible
Click Recommended tab
4.Verify search form is visible