Rename OlPagination event from update:page to ol-pagination-change#12072
Merged
Conversation
Rename the custom event to follow the ol-<component>-<action> convention.
Change detail payload from a bare number to { page: Number } object for
extensibility. Add cancelable support and prevent default handling.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
for more information, see https://pre-commit.ci
RayBB
approved these changes
Mar 11, 2026
RayBB
left a comment
Collaborator
There was a problem hiding this comment.
Put it on testing and it's working like a charm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{ page: Number }object for extensibility. Add cancelable support and prevent default handling.No code outside of our test page at https://openlibrary.org/developers/design is utilizing these features so it is low risk.
Stakeholders
@RayBB