Skip to content

Add mobile multi-diff view#318081

Merged
rebornix merged 14 commits into
mainfrom
rebornix/fascinating-camel
May 27, 2026
Merged

Add mobile multi-diff view#318081
rebornix merged 14 commits into
mainfrom
rebornix/fascinating-camel

Conversation

@rebornix
Copy link
Copy Markdown
Contributor

Introduces MobileMultiDiffView with sticky per-file headers, fold/unfold via a chevron-only toggle target (click, tap, keyboard), and async per-file content loading; wires it into the mobile overlay/titlebar plumbing and adds a Vite playground entry for iteration.

Introduces MobileMultiDiffView with sticky per-file headers, fold/unfold via a chevron-only toggle target (click, tap, keyboard), and async per-file content loading; wires it into the mobile overlay/titlebar plumbing and adds a Vite playground entry for iteration.
Copilot AI review requested due to automatic review settings May 23, 2026 06:01
@rebornix rebornix self-assigned this May 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new phone-focused multi-file diff overlay to the Agents (sessions) window, and routes the existing “changes” entry point to this stacked multi-diff experience for better mobile browsing of session outputs.

Changes:

  • Introduces MobileMultiDiffView, a full-screen overlay that renders multiple file diffs in one scroll view with sticky per-file headers and collapsible sections.
  • Updates the mobile “session changes” command to open multi-diff (or fall back to single-file diff when only one diffable file exists), with a notification when no file-level diffs are available.
  • Tweaks mobile diff/titlebar UI and shared overlay styles, plus adds a Vite playground page for iterating on the new multi-diff UI.
Show a summary per file
File Description
src/vs/sessions/contrib/sessions/browser/mobile/mobileOverlayContribution.ts Routes the mobile “changes” command to multi-diff (and single-diff shortcut), adds notification for no diffable files.
src/vs/sessions/browser/parts/mobile/mobileTitlebarPart.ts Adjusts “changes” pill visibility/content to support sessions with file changes but zero line deltas.
src/vs/sessions/browser/parts/mobile/contributions/mobileMultiDiffView.ts New multi-file diff overlay implementation with async per-file rendering and tokenization.
src/vs/sessions/browser/parts/mobile/contributions/mobileDiffView.ts Small header layout tweak (inline header info) and removes back label text.
src/vs/sessions/browser/parts/mobile/contributions/media/mobileOverlayViews.css Adds inline header layout and refines diff layout spacing/background.
src/vs/sessions/browser/parts/mobile/contributions/media/mobileMultiDiffView.css New styling for the stacked multi-diff view with sticky file headers and per-file horizontal scrolling.
build/vite/mobile-multi-diff.ts Adds a Vite playground TS entry that renders MobileMultiDiffView with mocked services/content.
build/vite/mobile-multi-diff.html Adds a Vite playground HTML page to host the multi-diff view for iteration.

Copilot's findings

  • Files reviewed: 8/8 changed files
  • Comments generated: 6

Comment thread src/vs/sessions/browser/parts/mobile/mobileTitlebarPart.ts Outdated
Comment thread src/vs/sessions/browser/parts/mobile/contributions/mobileMultiDiffView.ts Outdated
Comment thread src/vs/sessions/browser/parts/mobile/contributions/media/mobileMultiDiffView.css Outdated
Comment thread src/vs/sessions/browser/parts/mobile/mobileTitlebarPart.ts Outdated
@rebornix rebornix requested a review from osortega May 27, 2026 20:22
@rebornix rebornix marked this pull request as ready for review May 27, 2026 20:22
@rebornix rebornix merged commit dedf927 into main May 27, 2026
25 checks passed
@rebornix rebornix deleted the rebornix/fascinating-camel branch May 27, 2026 21:54
@vs-code-engineering vs-code-engineering Bot added this to the 1.123.0 milestone May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants