Skip to content

HttpExtension: allow setup CSP in report only mode#135

Closed
PavelJurasek wants to merge 1 commit into
nette:masterfrom
PavelJurasek:feature-1
Closed

HttpExtension: allow setup CSP in report only mode#135
PavelJurasek wants to merge 1 commit into
nette:masterfrom
PavelJurasek:feature-1

Conversation

@PavelJurasek

@PavelJurasek PavelJurasek commented Mar 11, 2018

Copy link
Copy Markdown
Contributor
  • bug fix? no
  • new feature? yes
  • BC break? no
  • doc PR: will do if accepted

CSP can now be enabled in report only mode. PR to nette/application will be sent in just a minute.

PavelJurasek added a commit to PavelJurasek/application that referenced this pull request Mar 11, 2018
PavelJurasek added a commit to PavelJurasek/application that referenced this pull request Mar 11, 2018
@dg

dg commented Mar 11, 2018

Copy link
Copy Markdown
Member

The question is whether it makes sense to use the headers Content-Security-Policy and Content-Security-Policy-Report-Only (with different settings) together?

I think it has, a Report-Only header can be used to test a future revision to a policy without actually deploying it.

@PavelJurasek

Copy link
Copy Markdown
Contributor Author

This commit allows only one of them to be enabled at a time. But I can actually see a case when I have a CSP policy and I want to experiment with more strict policy via Report only at the same time.

@dg

dg commented Mar 11, 2018

Copy link
Copy Markdown
Member

It would be better to add something like csp-report or csp-report-only section.

@PavelJurasek

Copy link
Copy Markdown
Contributor Author

In order to support both of them at the same time? I don't need this functionality at the moment, so maybe opening an issue with this feature description just to keep track of it would be enough for now?

@dg

dg commented Mar 11, 2018

Copy link
Copy Markdown
Member

It is good to think ahead. Will be possible to implement support for both header in a way that will co-exist with this solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants