TracyExtension: Don't dispatch Debugger in a CLI

[hranicka]

See #198

I've disabled Session/Debugger dispatching in for CLI SAPI.

It's needed only for Ajax.

[dg]

Thanks!

[hranicka]

This is the simplest possible solution, thanks @dg for your mentoring.

[JanTvrdik]

PHP_SAPI is not part of DI container cache key. The condition should IMHO be evaluated in runtime.

[hranicka]

@JanTvrdik I know, but this is same as:

• https://github.com/nette/http/blob/master/src/Bridges/HttpDI/HttpExtension.php#L57
• https://github.com/nette/http/blob/master/src/Bridges/HttpDI/SessionExtension.php#L66

Or not?

[dg]

It is "coincidentally" part of cache key, the question is whether make it official part of key, or modify implementation of extensions or leave it as is.

[hranicka]

There is also a parameter consoleMode here.

Does it have any impact on it? It's a part part of DIC cache key.

---

I can change this PR something like:

$initialize->addBody('if (PHP_SAPI !== 'cli' && $tmp = $this->getByType("Nette\Http\Session", FALSE)) { $tmp->start(); Tracy\Debugger::dispatch(); };');

But it seems unclear to me, I'm not sure with it.

[JanTvrdik]

@dg I think that it should be possible to generate DI container for application from CLI.

[dg]

It would actually be parameter for TracyExtension, like $debugMode .

[dg]

@hranicka can you change it this way? nette/http@27c3de5#diff-e18d2abacdd85c4cc65b1a8d611ca31f

[hranicka]

Ok, I edit it.

I've tried use config parameters with %consoleMode% but I must add more code because of this magic.

Constructor parameters seems better.

---

And what about Nette\Http packages? There is also PHP_SAPI constant. Ah, you edited this right now. Thanks :)

[dg]

👍

[hranicka]

I can prepare you PR into nette/bootstrap for your changes in nette/http and tracy. Give me a few minutes.

[dg]

I have it finished.

[hranicka]

Ok, thanks :)