Fix __set__ to __get__ in messages#13913
Merged
Merged
Conversation
Contributor
Author
|
@sobolevn 👁️ |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
hauntsaninja
left a comment
Collaborator
There was a problem hiding this comment.
If you encountered this in real code, want to add your test case?
Contributor
Author
TBH, I stumbled on it while reading the code and it threw me off :) An attempt to reproduce would be contrived: from typing import Any, TypeVar
T = TypeVar('T')
def decorator(f: T) -> T:
...
class Descriptor:
@decorator
def __get__(self, *args: Any, **kwargs: Any) -> int:
...
class Cls:
value: Descriptor
var = Cls()
_ = var.valueIn this case, plugin Without the decorator, |
sobolevn
approved these changes
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're dealing with the get descriptor here but calling it
__set__, probably a copy-paste from similar code elsewhere. I think this only affects messages.