Shaders: Improve types.#30789
Merged
Merged
Conversation
Collaborator
Ideally, each shader object has a name. That also improves shader debugging.
Yes, I think it's safe to remove the property in this PR.
I think we should move |
Mugen87
reviewed
Mar 24, 2025
Mugen87
reviewed
Mar 24, 2025
e5befdb to
206756f
Compare
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
206756f to
df987b2
Compare
Mugen87
approved these changes
Mar 24, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I am trying to improve the types for Shader passes. I try to make a single type that can be used and reference everywhere but I found some inconsistencies:
LuminosityHighPassShaderis using an old shaderID property (outdated I think)ConvolutionShaderis defining abuildKernelfunction that might just be passed as an utils like other shaders