WebGPURenderer: Fix MSAA using mipmap levels#31544
Merged
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Aug 1, 2025
Mugen87
approved these changes
Aug 1, 2025
Mugen87
reviewed
Aug 1, 2025
|
|
||
| msaaTextureDescriptorGPU.label = msaaTextureDescriptorGPU.label + '-msaa'; | ||
| msaaTextureDescriptorGPU.sampleCount = samples; | ||
| msaaTextureDescriptorGPU.mipLevelCount = 1; // See https://www.w3.org/TR/webgpu/#texture-creation |
Collaborator
There was a problem hiding this comment.
@sunag Should be report warning to the user if samples is set to a value greater than 0 and mipmapping is enabled? In engine components like FX modules, we can control this ourselves when creating render targets but I wonder if this kind of patch leads to unexpected behavior on user level.
Collaborator
There was a problem hiding this comment.
Hmm.. good question, I can't calculate it right away either, we can merge and test during the r180dev I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to the MDN-Documentation on createTexture, textures cannot have mipmap levels if they also use MSAA/samples. This fix aims to prevent blank render-targets, which specify both mipmaps and MSAA, see #31542 (comment)