WebGPUBindingUtils: Improve Bind Group Layout cache system.#32451
Merged
Conversation
Mugen87
commented
Dec 2, 2025
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Contributor
|
@Mugen87 Sorry I couldn't get to this earlier, I've been dealing with some health issues. I assume the issue was solved by just setting bindingsData.layout = undefined, which invalidates the deletion block? |
Collaborator
Author
|
It was the additional if ( bindingsData.layout ) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #32249
Description
Third attempt of improving the bind group layout system.
The deletion runtime error has been fixed with this PR and some additional refactoring has been done in
WebGPUBindingUtilsto simplify things. Hopefully, this should be good now.