Dashboard: event widget iteration#78815
Merged
Merged
Conversation
|
Size Change: 0 B Total Size: 8.21 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 7592bc8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26818199685
|
Contributor
|
Nice, these all seem like good changes! A couple of points, probably separate so feel free to ignore:
|
jameskoster
reviewed
May 29, 2026
| } } | ||
| > | ||
| <Stack direction="row" align="start" wrap="wrap" gap="sm"> | ||
| <Autocomplete.Root |
Contributor
There was a problem hiding this comment.
Should this be a combobox rather than autocomplete? 🤔
Member
Author
There was a problem hiding this comment.
Yep! I wrote that code some weeks ago, and I'm not sure if there just wasn't something available or what I concluded, but it needs revisiting. It's existing code, so best done in a separate PR.
retrofox
reviewed
May 29, 2026
Contributor
|
Maybe we should reword the message: 
Also, there is a visual issue when the input is focused: 
Probably out of the PR scope, tho. |
Contributor
|
It's related to my previous comment. There is a visual issue when focusing the location field. 
|
Render the "Want more events?" hint below DataViews in events-list and move its styling to events-list.module.css so list-specific UI stays co-located.
17e342c to
7592bc8
Compare
Member
Author
Yep; updated. 
Outline cutting is a good catch, but a good one for a follow-up. The input also doesn't render full-width in that settings panel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #78553
Part of #77616
What?
Iterates on experimental Events widget for experimental dashboard:
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
After
Longer list than can fit:
Only 1-2 events (just like core widget now):
Use of AI Tools
yes